Skip to content

bpo-43693 Get rid of CO_NOFREE -- it's unused - #26839

Merged
gvanrossum merged 4 commits into
python:mainfrom
faster-cpython:drop-nofree-flag
Jun 23, 2021
Merged

gvanrossum merged 4 commits into
python:mainfrom
faster-cpython:drop-nofree-flag

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jun 21, 2021 •

Copy link
Copy Markdown
Member

All uses of this flag are either setting it or in doc or tests for it. So we should be able to get rid of it completely.

https://bugs.python.org/issue43693

All uses of this flag are either setting it
or in doc or tests for it. So we should be
able to get rid of it completely.
@markshannon

Copy link
Copy Markdown
Member

I see you've skipped the news item. I've made https://bugs.python.org/issue44500 to remind us to document all these changes.

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gvanrossum
gvanrossum merged commit 769d7d0 into python:main Jun 23, 2021
@gvanrossum
gvanrossum deleted the drop-nofree-flag branch June 23, 2021 16:51
2elli added a commit to 2elli/python-xdis that referenced this pull request Aug 15, 2023
2elli added a commit to 2elli/python-xdis that referenced this pull request Aug 15, 2023
encukou added a commit to encukou/cpython that referenced this pull request Oct 15, 2026
…NOFREE

The constants were redefined in dis.py, and not perfectly kept in
sync: inspect.CO_NOFREE was kept even though the C define went away
in pythongh-26839.

- Expose the constants via `_opcode` (as agreed in pythongh-68656)
  and its wrapper `opcode`.
  This removes `CO_NOFREE` from `dis.COMPILER_FLAG_NAMES`.
- Re-add, deprecate and document inspect.CO_NOFREE
encukou added a commit to encukou/cpython that referenced this pull request Oct 15, 2026
…NOFREE

The constants were redefined in dis.py, and not perfectly kept in
sync: inspect.CO_NOFREE was kept even though the C define went away
in pythongh-26839.

- Expose the constants via `_opcode` (as agreed in pythongh-68656)
  and its wrapper `opcode`.
  This removes `CO_NOFREE` from `dis.COMPILER_FLAG_NAMES`.
- Re-add, deprecate and document inspect.CO_NOFREE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants